fix(windows): hide console windows for AEC, text-monitor, and mic-listener#1234
Merged
gabrielste1n merged 3 commits intoJul 19, 2026
Merged
Conversation
…tener Native Windows helper binaries were spawned without windowsHide, flashing consoles during meeting AEC, text-edit monitoring, and mic activity detection. Co-authored-by: Cursor <cursoragent@cursor.com>
gabrielste1n
self-requested a review
July 19, 2026 17:30
gabrielste1n
approved these changes
Jul 19, 2026
gabrielste1n
left a comment
gabrielste1n
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed and verified — the fix matches the established windowsHide pattern used across the other native helper spawns, and stdio behavior (including the mic-listener's stdin parent-death monitoring) is unchanged. I merged latest main into the branch, renamed the test to match the camelCase convention in test/helpers/, and tightened the assertions so windowsHide must appear inside each spawn's own options object. Full suite, lint, and typecheck are green. Thank you for the clean, well-scoped fix! 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windowsHide: meeting AEC, text-edit monitor, andwindows-mic-listener.exe.windowsHide: trueon those spawn sites (same pattern as whisper/ffmpeg/sidecar helpers).AI assistance
This PR was prepared with AI assistance (Cursor/Grok). Human author: Stan Shih (@stantheman0128). Please review carefully.
Verification / Evidence
Focused tests:
Test plan